Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade architecture - Android SDK33, AndroidX & MANAGE_EXTERNAL_STORAGE, closes #1359 #1521

Merged
merged 2 commits into from
Aug 11, 2022

Conversation

gsantner
Copy link
Owner

@gsantner gsantner commented Dec 4, 2021

Preparation of update to latest Android SDK, support libraries, file access & more

@gsantner gsantner self-assigned this Dec 4, 2021
@gsantner gsantner force-pushed the androidsdk-upgrade branch 4 times, most recently from 018d7f4 to 1876a96 Compare December 4, 2021 03:35
gsantner added a commit that referenced this pull request Dec 4, 2021
@gsantner gsantner force-pushed the androidsdk-upgrade branch 2 times, most recently from 743799c to dd0a5df Compare December 4, 2021 03:44
@gsantner
Copy link
Owner Author

gsantner commented Dec 4, 2021

I uploaded a test version to google play and requested the "sensitive" MANAGE_EXTERNAL_STORAGE permission for direct file access.

Uploaded "128 (v2.8.4)" from this branch to public testing. let's see what google says and if they agree and publish it.

At time of this comment it says this - which means it's not published (yet/denied)

image

@gsantner
Copy link
Owner Author

gsantner commented Dec 7, 2021

Google disagrees that a document & file manager should have direct file access.

At least having one of the written use cases should make the app Eligible to use this access type.
Markor is at least one of these to my opinion:

  • Document management apps
  • File management
  • Search (On Device)

grafik

Google says Markor is not eligable for it though. I asked for another review, but not looks like they change their mind.

@gsantner gsantner force-pushed the androidsdk-upgrade branch 2 times, most recently from 00f3cd1 to 79797d2 Compare December 10, 2021 11:19
@gsantner gsantner linked an issue Dec 11, 2021 that may be closed by this pull request
@gsantner gsantner marked this pull request as draft December 24, 2021 09:58
@gsantner
Copy link
Owner Author

gsantner commented Jan 4, 2022

Google denied my appeal request (wow !!appeal!! as like it would be a crime to read files).

image

Thus, I won't waste my time on this project with keeping Google happy anymore - main distribution channel is and continues to be F-Droid. (=No updates for Markor on Google Play anymore)

Markor also stays on Android SDK v29 till there is a real urgent need.

@gsantner
Copy link
Owner Author

gsantner commented Jan 4, 2022

@harshad1 @fredericjacob For your information

Dark1616
Dark1616 previously approved these changes Jan 6, 2022
@harshad1
Copy link
Collaborator

harshad1 commented Jan 6, 2022

Thus, I won't waste my time on this project with keeping Google happy anymore - main distribution channel is and continues to be F-Droid. (=No updates for Markor on Google Play anymore)

Would it be worth it to create a google play version where the notebook is restricted to Markor's app-specific storage?

@gsantner
Copy link
Owner Author

gsantner commented Jan 6, 2022

I don't really want to make a separate version for gplay, with separate type of issues, separate type of questions and people suddenly not being able to edit their existing files anymore.

@harshad1
Copy link
Collaborator

harshad1 commented Jan 6, 2022 via email

@fredericjacob
Copy link
Contributor

That's a really weird decision and argumentation for the rejection... Does Google tell apps with integrated cloud service access like Google Drive, Dropbox, etc. to consider "more privacy-friendly options", too? I think as well that Markor matches both the file manager and document manager criteria and thus should be compliant with the policy. Actually direct file access IS required to use Markor in synergy with other apps that access the same data, like synchronization via Syncthing etc.

However, I wouldn't give up on Google Play completely. I think the app could lose a big (especially non-techie) audience otherwise, which would be a shame because Markor is really outstanding in its field in terms of features and development, plus being FOSS... Maybe there's still a way to fight the rejection? Continue to argue why it IS compliant? Or like @harshad1 proposed, deploy a variant to Google Play, but maybe display a hint in the description that full file access is not possible in the Google Play version because of how Google interprets its own policy?

@fredericjacob
Copy link
Contributor

Maybe Google will listen if enough people complain :)

That's another hope I have. I think there were other popular apps that were banned from Google Play in a first place because of some "policy violation", but could celebrate a comeback after some heavy shitstorms on the internet. ;)

@gsantner
Copy link
Owner Author

gsantner commented Jan 9, 2022

apps that were banned from Google Play

noting: Markor is not banned at gplay, available as is in v2.8. Just can't deploy new updates without removing Markor's reason of existance.

@Ilithy

This comment was marked as off-topic.

@gsantner

This comment was marked as off-topic.

@gsantner gsantner changed the title WIP: Experimental Android SDK31 & all files access, closes #1359 WIP: Experimental Android SDK33 & all files access, closes #1359 Jul 16, 2022
@gsantner gsantner force-pushed the androidsdk-upgrade branch 5 times, most recently from a9f7ded to 8c1a9c7 Compare July 22, 2022 22:11
@harshad1
Copy link
Collaborator

FYI, after installing this I had to go into app info and give it full file permissions again.

I installed a release build with my local key

@gsantner
Copy link
Owner Author

Yes, API30+ not uses the Marshmallow storage one but the ManageExternalStorage in this PR

@gsantner gsantner force-pushed the androidsdk-upgrade branch 2 times, most recently from 1b8166a to 6b0162b Compare July 25, 2022 23:14
@gsantner gsantner force-pushed the androidsdk-upgrade branch 4 times, most recently from d757d40 to 0d8b7fe Compare August 6, 2022 13:03
@gsantner gsantner changed the title WIP: Experimental Android SDK33 & all files access, closes #1359 Upgrade architecture - Android SDK33, AndroidX & MANAGE_EXTERNAL_STORAGE, closes #1359 Aug 11, 2022
@gsantner gsantner added this to the Markor v2.11 milestone Aug 11, 2022
@gsantner gsantner merged commit e626eda into master Aug 11, 2022
@gsantner gsantner deleted the androidsdk-upgrade branch August 11, 2022 11:31
@gsantner
Copy link
Owner Author

Google Play has changed the opinion on the files permission now with the 2.10.1 submission and it passed reviews.
So merging this pull request and thus big, major architecture changes, to be ready for future Android versions and Android features.

@gsantner gsantner linked an issue Aug 17, 2022 that may be closed by this pull request
3 tasks
@gsantner gsantner linked an issue Aug 21, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment